D25058: Add KAboutPluginDialog, to be used with KPluginMetaData

[David Faure]

dfaure added a comment.


  Nice work.

INLINE COMMENTS

> kaboutplugindialog.cpp:119
> +        QWidget *translatorWidget = createTranslatorsWidget(pluginMetaData.translators(), QString(), q);
> +        tabWidget->addTab(translatorWidget, i18n("T&ranslation"));
> +    }

(I'm surprised by the explicit '&' in all those labels, doesn't KAcceleratorManager take care of this automatically?)

> kabstractaboutdialog_p.h:40
> +public:
> +    QWidget * createTitleWidget(const QPixmap &pixmap,
> +                                const QString &displayName,

Coding style: there should be no space after the *, right?

> klicensedialog_p.cpp:72
> +
> +    // TODO: this does not work anymore
> +    resize(sizeHint().expandedTo(QSize(qRound(idealWidth), idealHeight)));

Well, the code calls `resize` and then `adjustSize`, which calls `resize` itself. So at least one issue is that one of those two calls is redundant. Try removing `adjustSize`?

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D25058

To: kossebau, #frameworks, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191120/0d2a8532/attachment-0001.html>