D25414: xattr: fix crash on dangling symlinks

Stefan BrĂ¼ns noreply at phabricator.kde.org
Tue Nov 19 22:54:10 GMT 2019


bruns added inline comments.

INLINE COMMENTS

> usermetadatawritertest.cpp:44
> +    QFile tempTarget(testFilePath("temporal_target"));
> +    tempTarget.link(testFilePath(TEST_SYMLINK));
> +    tempTarget.remove();

You can just use the static overload and provide an invalid target name.
https://doc.qt.io/qt-5/qfile.html#link-1

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25414

To: iasensio, astippich, bruns
Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191119/030bbf9a/attachment.html>


More information about the Kde-frameworks-devel mailing list