D25414: xattr: fix crash on dangling symlinks

[Ismael Asensio]

iasensio created this revision.
iasensio added a reviewer: astippich.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
iasensio requested review of this revision.

REVISION SUMMARY
  When requesting metadata on a dangling symlink, the framestack ends up calling `k_queryAttributes` with the symlink path.
  There, the `listxattr` syscall returns `size=-1` and `errno=ENOENT` (2 No such file or directory), which was not covered before, and provoking a segfault on `QByteArray`. Full traceback on: https://bugs.kde.org/show_bug.cgi?id=414227
  
  It might be also a good idea to protect the function in any other cases where `size=-1`
  
  BUG: 414227

TEST PLAN
  On dolphin, with panel information open, hover over a dangling symlink

REPOSITORY
  R286 KFileMetaData

BRANCH
  fix_symlink

REVISION DETAIL
  https://phabricator.kde.org/D25414

AFFECTED FILES
  src/xattr_p.h

To: iasensio, astippich
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191119/c40859de/attachment.html>