D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

David Edmundson noreply at phabricator.kde.org
Mon Nov 18 12:49:08 GMT 2019


davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in sortfiltermodel.h:78
> > presumably for some reason.
> 
> Either because someone was too lazy to use the respective property on the `Repeater` or `ListView` or before `rowCount()` was `Q_INVOKABLE`. Not sure it's upstreamable since it assumes it's a flast list. Maybe something for QAbstract*List*Model rather than QAbstract*Item*Model

rowCount being invokable seems enough in the cases I've found in Plasma, will drop this.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D25326

To: davidedmundson
Cc: broulik, ahiemstra, mart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191118/fb76cce2/attachment.html>


More information about the Kde-frameworks-devel mailing list