D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

[Xuetian Weng]

xuetianweng added a comment.


  Any idea about how konsole derive
  
  In D25339#563656 <https://phabricator.kde.org/D25339#563656>, @cullmann wrote:
  
  > The issue with this approach is, that you get "too high" lines for the case that none of this characters ever appear.
  >  Beside that, unfortunately, you get rendering artifacts in addition, as Qt will not paint e.g. selection high enough for lines without such chars.
  >
  > See e.g. attached screenshot.F7768081: rendering_issue.png <https://phabricator.kde.org/F7768081>
  
  
  Then what is the ideal solution to you for this case?
  
  Having different font height for every line? Or keep this "slightly higher line" by do vertical center align  and fix the artifact?
  
  At least the current state doesn't look right to me and I think it need to be fixed.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann
Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191117/4c910d00/attachment.html>