D25334: Added transparent blue background to tabbars
Noah Davis
noreply at phabricator.kde.org
Sat Nov 16 17:49:33 GMT 2019
ndavis added a comment.
In D25334#563295 <https://phabricator.kde.org/D25334#563295>, @niccolove wrote:
> In D25334#563285 <https://phabricator.kde.org/D25334#563285>, @ngraham wrote:
>
> > Perfect, all issues fixed, and thanks for pointing me in the direction of the cache files. Deleting those fixed a bunch of other issues I was having with applying plasma theme SVG changes.
>
>
> Did it fix the shadows? I can't apply my own shadows to the new distro I'm using.
>
> Regarding this task, I just realized a possible problem:
> I originally copied this effect from the highlight effect that's used when you hover on applications, which uses a 3px blue line:
> F7766664: Screenshot_20191116_164209.png <https://phabricator.kde.org/F7766664>
> But then, tweaking things around, I realized that a 2px line looks way better in my panel, imo:
> F7766666: Screenshot_20191116_164303.png <https://phabricator.kde.org/F7766666>
> Therefore right now this effect and the application hover effect are inconsistent. I'm not a fan of bringing back that 3px line though. Do you think I should change the application top lines, or leave them as-is?
If we use a 2px line here, then using a 2px outline for button focus in D24706 <https://phabricator.kde.org/D24706> would be more acceptable. If a 2px line looks good in the task manager, it might be worth making the change.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D25334
To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191116/55196daf/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list