D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

[Arjen Hiemstra]

ahiemstra added inline comments.

INLINE COMMENTS

> sortfiltermodel.h:63
> +     */
> +    Q_PROPERTY(QString filterRole READ filterRole WRITE setFilterRole)
> +

This (and sortRole below) hides the properties from QSortFilterProxy with the same name. Maybe it is a better idea to use filterRoleName/sortRoleName?

> sortfiltermodel.h:74
> +    Q_PROPERTY(Qt::SortOrder sortOrder READ sortOrder WRITE setSortOrder)
> +
> +    /**

Having a sortColumn property would also be useful, since that is apparently missing from QSortFilterProxy. I seem to recall that was added to the Plasma version a while ago.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D25326

To: davidedmundson
Cc: ahiemstra, mart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191115/1532ec06/attachment-0001.html>