D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

David Edmundson noreply at phabricator.kde.org
Fri Nov 15 11:36:18 GMT 2019


davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  It exposes QSFPM in a usable way from QML, but also exposes a way to
  perform JS callbacks as an advanced filter method.
  
  This is mostly a 1-1 move from plasma-frameworks, but with the following
  change.
  
  - Removing a broken workaround for trying to handle Plasma's DataModel
  
  having dynamic role names.
  
  - port to the new connect syntax
  - removing the plasma namespace
  
  I don't know if we want to change the name to match the others having a
  K prefix?
  
  I can add a unit test if that

REPOSITORY
  R275 KItemModels

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25326

AFFECTED FILES
  src/qml/CMakeLists.txt
  src/qml/plugin.cpp
  src/qml/sortfiltermodel.cpp
  src/qml/sortfiltermodel.h

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191115/bdf83658/attachment.html>


More information about the Kde-frameworks-devel mailing list