D25296: [RFC] Fix Display Configuration icon margins

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> preferences.svg:4
> +        <style id="current-color-scheme" type="text/css">.ColorScheme-Text {
>          color:#7B7C7E;
>        }

Wrong default colors. Just replace the whole stylesheet with this one: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Breeze

> preferences.svg:36
> +      }</style>
> +        <style id="current-color-scheme-5" type="text/css">.ColorScheme-Text {
>          color:#31363b;

You have 2 embedded stylesheets, although I doubt the 2nd one actually works since the ID isn't correct. You can delete the 2nd one.

> preferences.svg:73
> +        <path id="rect7235" class="ColorScheme-Text" d="m7.0000091 19.062486h10.000018v1.000014h-10.000018zm3.0000049-1.999998h3.999994v1.999983h-3.999994zm-7.062514-13.062482v13.062468h18.124999v-13.062468zm0.9999988 0.999999h16.125001v9.0624725h-16.125001z" color="#31363b" fill="currentColor"/>
> +        <path id="rect3018" class="ColorScheme-Text" d="m4.9375 9.0625 4 4h-4z" color="#31363b" fill="currentColor"/>
> +        <path id="path3028" class="ColorScheme-Text" d="m19.0625 10-4-4h4z" color="#31363b" fill="currentColor"/>

Hardcoded color

> preferences.svg:74
> +        <path id="rect3018" class="ColorScheme-Text" d="m4.9375 9.0625 4 4h-4z" color="#31363b" fill="currentColor"/>
> +        <path id="path3028" class="ColorScheme-Text" d="m19.0625 10-4-4h4z" color="#31363b" fill="currentColor"/>
> +    </g>

Hardcoded color. Inkscape does this to any element of the SVG you modify.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25296

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191115/447a97bc/attachment-0001.html>