D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

Alexander Saoutkin noreply at phabricator.kde.org
Fri Nov 15 00:10:58 GMT 2019


feverfew marked 8 inline comments as done.
feverfew added inline comments.

INLINE COMMENTS

> sitter wrote in desktopexecparser.cpp:317
> There's nothing wrong with this. But wouldn't using `QHash<QDBusPendingReply<QString>, QUrl>` make for easier to read code all in all since you don't have to mess with pairs?
> 
> Alternatively with a vector I'd still make a struct for the data
> 
>   struct MountRequest { QDBusPendingReply<QString> reply, QUrl url };
>   QVector<MountRequest> requests;
>   ...
>   requests.push_back({ mountUrl(url), url });

Gone for the vector option.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23384

To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191115/d85878ed/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list