D25272: Turn KNewStuffQuick::CommentsModel into a SortFilterProxy for reviews

Dan Leinir Turthra Jensen noreply at phabricator.kde.org
Tue Nov 12 13:32:38 GMT 2019


leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  This adds a new property which allows the user to ask the model
  to filter its contents by whether or not a comment has a rating
  (which means we consider it a review), and optionally to include
  the replies to those reviews.
  
  The filtering options are added as contextual actions on the
  comments page, so they easily integrate with the Kirigami-esque
  navigation methods

REPOSITORY
  R304 KNewStuff

BRANCH
  allow-filtering-comments-by-rating-state (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25272

AFFECTED FILES
  src/core/commentsmodel.cpp
  src/qtquick/commentsmodel.cpp
  src/qtquick/commentsmodel.h
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/private/EntryCommentsPage.qml

To: leinir
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191112/1c6eff29/attachment.html>


More information about the Kde-frameworks-devel mailing list