D25223: Avoid side effects during menu initialization

[Konrad Materka]

kmaterka added inline comments.

INLINE COMMENTS

> kdeplatformsystemtrayicon.cpp:191
> +    if (!m_visible.isNull()) {
> +        m_menu->setVisible(m_visible.value<bool>());
> +    }

This line was causing issues, even if menu is (or should be) visible, setting true has side effects.
I checked the code of QMenu, QPlatformMenu::setVisible is never used anyway...

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D25223

To: kmaterka, #plasma, #frameworks, broulik
Cc: cgiboudeaux, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191110/f70f1a0a/attachment.html>