D25223: Avoid side effects during menu initialization

[Konrad Materka]

kmaterka created this revision.
kmaterka added reviewers: Plasma, Frameworks, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kmaterka requested review of this revision.

REVISION SUMMARY
  Setting some attributes, like visible, enabled, etc has side effects. Do
  not set them if these are not changed.

TEST PLAN
  Without this change menus (mostly submenus) randomly shows up when the SNI is updated, e.g. every time VLC changes a track I get its "speed (slower, normal, faster)" menu open.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25223

AFFECTED FILES
  src/platformtheme/kdeplatformsystemtrayicon.cpp

To: kmaterka, #plasma, #frameworks, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191108/cc13e25f/attachment.html>