D25106: Also allow invoking session restoration logic when apps are manually launched

[David Edmundson]

davidedmundson added a comment.


  > KConfigGui::sessionConfig();
  
  This method behaves weirdly and not what I expected from reading this code.
  
  If no-one has explicitly called KConfigGui::sessionConfig it creates a new one using qApp->sessionConfig() regardless of whether we're session restored or not. If we're not sessionRestored it'll effectively leak a bogus config with a broken ID name.
  
  I think  to accept the patch we would need to also change
  
  kconfiggui.cpp:42 to be
  
  - if (!hasSessionConfig()) {
  
  +     if (!hasSessionConfig() && qApp->isSessionRestored()) {

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D25106

To: ngraham, davidedmundson, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191108/63bd3dbe/attachment-0001.html>