D24962: [DeleteJob] Use a separate worker thread to run actual IO operation
Méven Car
noreply at phabricator.kde.org
Wed Nov 6 09:04:14 GMT 2019
meven added inline comments.
INLINE COMMENTS
> deletejob.cpp:130
> + /// Callback of worker rmfile
> + void rmFileResult(bool result, bool isLink);
> + /// Callback of worker rmdir
Now we are at it, isLink could become m_curentURLIsLink, but isLink being a bool, it is much cheaper to move around threads, so we don't have perf incentive to do it as we had with a QString.
REPOSITORY
R241 KIO
BRANCH
arcpatch-D24962
REVISION DETAIL
https://phabricator.kde.org/D24962
To: meven, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191106/e6190381/attachment.html>
More information about the Kde-frameworks-devel
mailing list