D25159: Fix linking to libssh 0.9.1

[Harald Sitter]

sitter added a comment.


  In D25159#559016 <https://phabricator.kde.org/D25159#559016>, @asn wrote:
  
  > We moved from a manually generated libssh-config.cmake to install(EXPORTS libssh-config) and it does things completely different.
  >
  > I'm currently trying to fix it. However better don't apply this as ssh_shared will vanish as a target.
  >
  > I wonder how I can define LIBSSH_LIBRARIES again with EXPORTS.
  
  
  I am not super certain, but I don't think you can as that is pretty much exactly where configure_package_config_file would be used. We certainly do use it that way all over KDE frameworks.
  
  Btw about the ssh_shared target. It may make sense to settle on a target name and use that moving forward and advertise it as the recommended way of using libssh. IMPORTED targets are vastly preferred over the _LIBRARES/_INCLUDE_DIRS variables from a cmake POV because the targets can inject include dirs, flags and the likes without the library user having to worry about anything. So they are nicer to use in cmake. Just something to think about perhaps.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D25159

To: arojas, apol, sitter
Cc: sitter, asn, apol, asturmlechner, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191105/4f4fc2cf/attachment-0001.html>