D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[David Faure]

dfaure added a comment.


  You could use KIOCORE_ENABLE_DEPRECATED_SINCE(5, 65) to already put in place the trigger for the compat code to disappear when KF6 comes around, like you did in file_unix.cpp.
  It will also make it easier for the future developer who cleans this up.
  
  I mean deletejob.cpp:401, directorysizejob.cpp:137, those places with a "TODO KF6".

INLINE COMMENTS

> meven wrote in listjobtest.cpp:44
> > Does KIO::DefaultDetails make sense beyond stat in the KIO namespace? How does it match other similar flags?
> 
> It was @kossebau concern as well.
> 
> I am open to suggestion to improve on that, maybe this enum should be in KIO namespace ?
> In the meantime, it was what was made the most sense to me.

Well if it's called KIO::StatDefaultDetails (with the extra "Stat" compared to the question above), then it doesn't need to be in KIO::StatJob.

So yes, you could move the enum to the KIO namespace and define it in src/core/global.h
This will keep the two jobs a bit more separate (no need to add #include "statjob.h" in a few places)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191103/54b42344/attachment.html>