D25117: file ioslave: stop copying as soon as the ioslave is killed

Méven Car noreply at phabricator.kde.org
Sat Nov 2 12:28:01 GMT 2019


meven created this revision.
meven added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Previously when cancelling a copy the ioslave would continue.
  The file copy job would then remove the file.
  The dest file being removed would cause an IO error in the slave resulting in warnings such as :
  
    kf5.kio.kio_file: Could not change permissions for "...
    kf5.kio.kio_file: Couldn't preserve group for "...
    kf5.kio.kio_file: Couldn't preserve access and modification time for "...
  
  Preserve clean up of intermediate file copy leftover.

TEST PLAN
  Copy a file, cancel the copy -> the destination file is cleaned
  Copy a file, overwriting another -> the .part intermediate file is cleaned

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25117

AFFECTED FILES
  src/core/filecopyjob.cpp
  src/core/filecopyjob.h
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/file_win.cpp

To: meven, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191102/a96c5706/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list