D21379: [UDev Backend] Narrow subsystems queried for cameras

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> udevqtclient.cpp:223
> +    for (const QString &subsystem : subsystems) {
> +        udev_enumerate_add_match_subsystem(en, subsystem.toLatin1().constData());
> +    }

Nitpick - the existing code uses `toLatin1()`, and for the ASCII subset it doesn't matter, but I am quite sure properties and values are UTF8 in general.

I have no strong proof, but the udev changelog has:

> udev 069
>  ========
>  A bunch of mostly trivial bugfixes. From now on no node name or
>  symlink name can contain any character than plain whitelisted ascii
>  characters or validated **utf8** byte-streams. This is needed for the
>  /dev/disk/by-label/* links, because we import untrusted data and
>  export it to the filesystem.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21379

To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190529/cc4c6268/attachment.html>