D21315: Dolphin-style view modes in the file dialog

[Nathaniel Graham]

ngraham added a comment.


  This is fantastic. You fixed all the issues I was having, and the UX is practically perfect. The code looks totally sane too. In my testing I found only one small issue: when changing the icon size in one view and then switching to another view and then back, the first view did not save the new size; saving icon sizes only happens when closing the window. With more view modes prominently exposed now, it might be nice to save newicon  sizes instantly, or when switching to a different view, rather than only saving when closing the dialog.

INLINE COMMENTS

> kdiroperator.cpp:2022
>  
> +    KToggleAction *allowExpansionAction = new KToggleAction(i18n("Allow Expansion"), this);
> +    d->actionCollection->addAction(QStringLiteral("allow expansion"), allowExpansionAction);

Now I wonder if this should say "Allow expansion in Details view" and not disable itself when using a different view. Otherwise it might be hard for people to figure out what it does or how to activate it.

> kdiroperator.h:963
>      Q_PRIVATE_SLOT(d, void _k_slotDirectoryCreated(const QUrl &))
> +
>  };

Unnecessary whitespace change

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190521/a858dc12/attachment-0001.html>