D21298: Add example app for printing highlighted text to pdf
Dominik Haumann
noreply at phabricator.kde.org
Mon May 20 06:24:14 BST 2019
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
I ngeneral looks good to me. Maybe use ecm_optional_add_subdirectory - this also allows 3rd party users to omit the code and it still works.
INLINE COMMENTS
> CMakeLists.txt:6
> +
> +add_subdirectory(codepdfprinter)
Maybe we use the optional variant like:
ecm_optional_add_subdirectory (codepdfprinter)
REPOSITORY
R216 Syntax Highlighting
BRANCH
addpdfprintingexample
REVISION DETAIL
https://phabricator.kde.org/D21298
To: kossebau, vkrause, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190520/13a7f6a5/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list