D21249: Test current filter before setting a new one

[Jan-Marek Glogowski]

jglogowski updated this revision to Diff 58291.
jglogowski added a comment.


  Changes:
  
  - Dropped the duplicate comment in matchFilter (not sure if it makes sense at all)
  - Replace bool param with enum class to improve readability - should have done this from the start
  - Drop const from enum as requested; I like useing const wherever possible setting preconditions…
  
  Remarks:
  
  - Wondering why there is still this foreach... maybe was just missed
  - Naming is hard and I couldn't come up with something I really liked (MatchPoliy vs MatchAction etc.)

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21249?vs=58215&id=58291

REVISION DETAIL
  https://phabricator.kde.org/D21249

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: jglogowski, #frameworks, ngraham, dfaure
Cc: elvisangelaccio, ngraham, michaelweghorn, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190519/cfd01252/attachment.html>