D21280: kioslave: preserve argv[0], to fix applicationDirPath() on non-Linux

Anthony Fieroni noreply at phabricator.kde.org
Sun May 19 05:57:31 BST 2019


anthonyfieroni added inline comments.

INLINE COMMENTS

> kioslave.cpp:132
> +    const int newArgc = argc - 1;
> +    char ** newArgv = new char*[newArgc];
> +    newArgv[0] = argv[0];

Now has a leak, use vector instead.

REPOSITORY
  R241 KIO

BRANCH
  2019_freebsd_fixed

REVISION DETAIL
  https://phabricator.kde.org/D21280

To: dfaure, sitter, davidedmundson, apol, adridg
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190519/f583fade/attachment.html>


More information about the Kde-frameworks-devel mailing list