D21280: kioslave: preserve argv[0], to fix applicationDirPath() on non-Linux

David Faure noreply at phabricator.kde.org
Sat May 18 23:50:27 BST 2019


dfaure created this revision.
dfaure added reviewers: sitter, davidedmundson, apol, adridg.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  Linux has /proc so it doesn't matter there, but e.g. on FreeBSD
  lying about argc[0] leads to applicationDirPath() being wrong,
  which leads to the kioslave executable not being found in CI
  (because it's looking in applicationDirPath(), which for a kioslave
  was build/bin/kf5/kio, where e.g. trash.so can be found)

TEST PLAN
  commenting out the Q_OS_LINUX block in qcoreapplication.cpp,
  uninstalling kio, then running `bin/dropjobtest shouldDropFromTrash`.
  Failed with "kioslave not found", works after this fix.

REPOSITORY
  R241 KIO

BRANCH
  2019_freebsd_fixed

REVISION DETAIL
  https://phabricator.kde.org/D21280

AFFECTED FILES
  src/kioslave/kioslave.cpp

To: dfaure, sitter, davidedmundson, apol, adridg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190518/92fe2faf/attachment.html>


More information about the Kde-frameworks-devel mailing list