D21204: Ensure no trailing slash in mountpoint read from fstab file.
Stefan BrĂ¼ns
noreply at phabricator.kde.org
Fri May 17 18:48:35 BST 2019
bruns added inline comments.
INLINE COMMENTS
> fstabhandling.cpp:140
> +
> + // strips last slash so that the device matches the one returned by getmntent when filesystem is mounted
> + // even when fstab mnt_dir ends with a '/' in /etc/fstab
break @ < 80 chars
> fstabhandling.cpp:142
> + // even when fstab mnt_dir ends with a '/' in /etc/fstab
> + if (source.endsWith((QLatin1Char('/')))) {
> + QString deviceName(source);
that likely breaks for "server:/" NFS mounts
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D21204
To: meven, bruns, #frameworks
Cc: ngraham, bruns, apol, kde-frameworks-devel, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190517/a5115d33/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list