D21146: KProcessInfoList -- add proclist backend for FreeBSD

[Adriaan de Groot]

adridg added inline comments.

INLINE COMMENTS

> kprocesslist_unix_proc.cpp:56
>  #else
> +#  ifdef Q_OS_FREEBSD
> +    static const char formatC[] = "pid,state,user,command";

Are there situations where you would end up here? I mean, libprocstat is in base, since 9.0, so it is unlikely to be gone at any point.

> kprocesslist_unix_procstat.cpp:38
> +    struct procstat *pstat;
> +    pstat = procstat_open_sysctl();
> +

I absolutely have Opinions on C++ style that apply here, so I'm going to talk to Tobias elsewhere.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21146

To: tcberner, #freebsd, adridg, davidedmundson
Cc: pino, apol, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190513/7f4827b8/attachment.html>