D21146: KProcessInfoList -- add proclist backend for FreeBSD

[Pino Toscano]

pino added a comment.


  What about create a separate kprocesslist_libprocstat.cpp (or so) to implement `KProcessList::processInfoList()` using libprocstat, instead of overloading the existing kprocesslist_unix.cpp?
  
  Also, please adjust the coding style to the kdelibs coding style: https://community.kde.org/Policies/Kdelibs_Coding_Style
  In addition to that, IMHO you can simplify all the various statements like
  
    type foo;
    foo = ...;
  
  to
  
    type foo = ...;

INLINE COMMENTS

> kprocesslist_unix.cpp:170-172
> +#ifdef HAVE_PROCSTAT
> +    return unixProcessListKinfoProcStat();
> +#endif

this makes the rest of the function as unreachable code, and compilers might warn about that

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21146

To: tcberner, #freebsd, adridg, davidedmundson
Cc: pino, apol, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190512/8254c533/attachment.html>