D21109: Fix KAr
Albert Astals Cid
noreply at phabricator.kde.org
Thu May 9 23:25:53 BST 2019
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.
REVISION SUMMARY
The bytearray needs to be 60 long if we read 60 chars not 61, otherwise
when doing endsWith it compares to the last uninitialized char and it's
always false
Comes with an unittest to prove it can at least open a simple .a archive
with two files inside
It has been broken for 6 years so probably noone cares, but better to
have it working ^_^
REPOSITORY
R243 KArchive
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D21109
AFFECTED FILES
.gitignore
autotests/data/artest.a
autotests/karchivetest.cpp
autotests/karchivetest.h
src/kar.cpp
To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190509/e2c23766/attachment.html>
More information about the Kde-frameworks-devel
mailing list