D21028: add multiple gestures and a handler class to KWidgetsAddons

[Steffen Hartleib]

steffenh added a comment.


  Hi @apol,
  
  Thanks for your time to look at my code. I know, I'am not good at this, so if you can point me at my errors I will try to correct this.

INLINE COMMENTS

> apol wrote in koneandtwofingerswipe.h:36
> Why is this commented out?

Oops this should not be here, it is a left over from gwenview.

> apol wrote in koneandtwofingerswipe.h:50
> If classes are installed and exported they should have a d-pointer.

Ok, I will add a private class for all exported classes.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D21028

To: steffenh, #frameworks
Cc: apol, nicolasfella, cfeck, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190508/3ad7e6a3/attachment.html>