D20833: Simpler check for flatpak

Jan Grulich noreply at phabricator.kde.org
Mon May 6 20:01:33 BST 2019


jgrulich added a comment.


  Lookgs good to me, I'll wait for Kai to approve this since he is the maintainer. One thing to consider maybe, did /.flatpak-info always exist or is it something new? I always assumed there is just one flatpak-info file in $XDG_RUNTIME_DIR. Just to be sure it will work for older Flatpak versions.

INLINE COMMENTS

> broulik wrote in knotificationmanager.cpp:94
> Do you need this check now, even, since you're not using it anymore?

I think Kai is right, since there is /.flatpak-info (which I didn't know about until now), you don't need to check $XDG_RUNTIME_DIR.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D20833

To: apol, #frameworks
Cc: jgrulich, broulik, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190506/1419f5f4/attachment.html>


More information about the Kde-frameworks-devel mailing list