D20838: Allow to drop one file or one folder on KDirOperator

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Still works great, and I have just a few code change requests. Then let's aim to land this early in the 5.59 cycle so it gets lots of testing.

INLINE COMMENTS

> meven wrote in kdiroperator.cpp:418
> Not sure I have done this correctly.

Yep, I'd say so now.

> kdiroperator.cpp:1404
> +
> +        this->setFocus();
> +

`this->` not needed

> kdiroperator.cpp:1418
> +                auto urlSetterClosure = [this, url](){
> +                    this->setCurrentItem(url);
> +                    QObject::disconnect(d->m_connection);

`this->` not needed

> kdiroperator.cpp:1423
> +            } else {
> +                this->setCurrentItem(url);
> +            }

`this->` not needed

> kdiroperator.cpp:1558
>  
> +    if (this->acceptDrops()) {
> +        newView->setAcceptDrops(true);

`this->` not needed

> kfilewidgettest_gui.cpp:36
>  }
> -

Unnecessary whitespace change.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20838

To: meven, ngraham
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190505/d2e2eb10/attachment.html>