D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files
Christoph Roick
noreply at phabricator.kde.org
Sun May 5 14:43:06 BST 2019
croick added a comment.
In D19420#460766 <https://phabricator.kde.org/D19420#460766>, @apol wrote:
> Looks good to me, have you checked that it's now not breaking what @broulik found?
Yes, I tested loading systemsettings.svg (`/usr/share/icons/breeze/apps/48/systemsettings.svg`) by using #kate <https://phabricator.kde.org/tag/kate/> and renaming the suffix to `.svgz`. With my previous commit 96083005e90e <https://phabricator.kde.org/R243:96083005e90e1f4b0bfe8aa6344e60c1f1cdcc77>, the file would not be loaded entirely. Using this patch, all of the file is loaded.
I don't compile plasma myself, so I didn't check whether the icons are displayed now. But the reason for not rendering the icons is gone.
REVISION DETAIL
https://phabricator.kde.org/D19420
To: croick, broulik, #frameworks
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190505/d7e478dd/attachment.html>
More information about the Kde-frameworks-devel
mailing list