D20958: New menu of syntax highlighting in the status bar
Dominik Haumann
noreply at phabricator.kde.org
Fri May 3 23:04:51 BST 2019
dhaumann added a comment.
My comments are very vague, but I think this patch could even be better. Only did a review half through due to lack of time.
INLINE COMMENTS
> katemodemenulist.h:141
> + */
> + class ModeListWidget : public QListWidget
> + {
Can you make this a QListView? I once heard the QListWidget will be deprecated in Qt6, rule of thumb is: always use Q***View instead of Q***Widget, since this then will also work in QML.
> katemodemenulist.h:175
> + */
> + class ModeListWidgetItem : public QListWidgetItem
> + {
This should use QStandardItem, iiuc.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D20958
To: nibags, #ktexteditor, #kate, #vdg
Cc: dhaumann, anthonyfieroni, cullmann, ngraham, loh.tar, kwrite-devel, kde-frameworks-devel, domson, michaelh, bruns, demsking, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190503/ba3e60cf/attachment.html>
More information about the Kde-frameworks-devel
mailing list