D21002: Remove kde4 migration agent completely

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Frameworks, cfeck.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The migration agent is some quite weird mechanism:
  
  - it starts the KDE4 kwalletd
  - to do this, it asks DBus to start it
  - as the old kwalletd never shipped a service file, kwalletd5 ships a service file for kwalletd(4), hardcoding its likely path.
  - it merges the old wallets via DBus requests
  
  When the migration has finished, a flag is set in the config and on the
  next start, the migration agent is skipped. When the migration fails
  (e.g. because kwalletd(4) is not installed), the migration is attempted
  on each start.
  
  Shipping a a service file pointing to the old daemon also breaks
  autostart of kwalletd5 for old applications - kwalletd5 provides the
  kwalletd interface, but only if it has been started already. This leads
  to a race during startup.
  
  See D16520 <https://phabricator.kde.org/D16520> - proper kwalletd dbus service file for the legacy name
  CCBUG: 400462

REPOSITORY
  R311 KWallet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21002

AFFECTED FILES
  src/runtime/kwalletd/CMakeLists.txt
  src/runtime/kwalletd/kwalletd.h
  src/runtime/kwalletd/main.cpp
  src/runtime/kwalletd/migrationagent.cpp
  src/runtime/kwalletd/migrationagent.h
  src/runtime/kwalletd/migrationwizard.cpp
  src/runtime/kwalletd/migrationwizard.h
  src/runtime/kwalletd/migrationwizard1.ui
  src/runtime/kwalletd/migrationwizard2.ui
  src/runtime/kwalletd/org.kde.kwalletd.service

To: bruns, #frameworks, cfeck
Cc: kde-frameworks-devel, damjang, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190503/0293b649/attachment-0001.html>