D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Fri May 3 16:28:45 BST 2019
apol added inline comments.
INLINE COMMENTS
> ngraham wrote in kfilewidget.cpp:745
> I did it in `setMimeFilter` since that's where it's determined whether or not there's a limited assortment of mimetypes, which is what controls what the string should be. Conditionalizing it based on mode seemed safe enough considering that there's mode-specific code a few lines above, on 741.
::setOperationMode would need to update that as well, no? Then it would need splitting into a separate function, otherwise
setOperationMode(Saving); setOperationMode(Opening) will have the wrong behaviour.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20964
To: ngraham, #vdg, elvisangelaccio, GB_2
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190503/0014d9c4/attachment.html>
More information about the Kde-frameworks-devel
mailing list