D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons
Dan Leinir Turthra Jensen
noreply at phabricator.kde.org
Thu May 2 09:53:28 BST 2019
leinir added inline comments.
INLINE COMMENTS
> GridDelegate.qml:147
> + onClicked: {
> + delegate.clicked()
> + modelData.trigger()
Just came across having both a function called on clicking the thumbnail (using the onClicked handler) and on actions being triggered, and both now get triggered at the same time. Was this a deliberate choice? I can of course work around it by not using the onClicked handler and just putting a click handler into the thumbnail delegate, but it seems like this is the sort of thing the GridDelegate is supposed to avoid :) (for my purposes: clicking the thumbnail opens a page with detailed information about the item represented by the thumbnail, and clicking the action causes things to be done to the item without opening that page).
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D18649
To: ngraham, #vdg, #plasma, broulik, GB_2, ndavis
Cc: leinir, Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190502/12be7559/attachment.html>
More information about the Kde-frameworks-devel
mailing list