D20143: ora:kra: qstrcmp -> qstrncmp

Albert Astals Cid noreply at phabricator.kde.org
Sun Mar 31 20:21:13 BST 2019


aacid marked 4 inline comments as done.
aacid added inline comments.

INLINE COMMENTS

> apol wrote in kra.cpp:21
> how about calling it s_mimetype?

nyeeee. It happens to be the mimetype, but here we're using it as magic to detect if the file is a file we care about or not, i'd prefer to keep it calling magic tbh

REPOSITORY
  R287 KImageFormats

REVISION DETAIL
  https://phabricator.kde.org/D20143

To: aacid
Cc: apol, pino, security-team, rempt, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190331/14a94b07/attachment.html>


More information about the Kde-frameworks-devel mailing list