D20147: Improve executable dialog buttons' icons

Nathaniel Graham noreply at phabricator.kde.org
Sun Mar 31 20:12:38 BST 2019


ngraham created this revision.
ngraham added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The buttons were using mimetype icons, which don't change their colors to reflect the theme, and aren't designed for display at those sizes inside buttons.
  
  BUG: 406090
  FIXED-IN: 5.57

TEST PLAN
  Before, light: F6739736: Before.png <https://phabricator.kde.org/F6739736>
  After, light: F6739737: After.png <https://phabricator.kde.org/F6739737>
  Before, dark: F6739744: Before, dark.png <https://phabricator.kde.org/F6739744>
  After, dark: F6739746: After, dark.png <https://phabricator.kde.org/F6739746>

REPOSITORY
  R241 KIO

BRANCH
  improve-execute-dialog-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20147

AFFECTED FILES
  src/widgets/executablefileopendialog.cpp

To: ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190331/416eccf4/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list