D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

[Fabian Vogt]

fvogt added a comment.


  In D20096#440923 <https://phabricator.kde.org/D20096#440923>, @meven wrote:
  
  > In D20096#440921 <https://phabricator.kde.org/D20096#440921>, @fvogt wrote:
  >
  > > In D20096#440919 <https://phabricator.kde.org/D20096#440919>, @meven wrote:
  > >
  > > > So unless I am mistaken, I feel this is not a great concern.
  > > >  I would perhaps need to restrict when statx is used even when `STATX_BASIC_STATS` is defined to when __GLIBC__ is defined as well.
  > >
  > >
  > > Yes, please do that.
  >
  >
  > Will do.
  >
  > And thinking again about the issue, could we have kio compiled with glibc but running on a system with musl for instance ?
  >  If it is possible, then I need to treat this case as you suggested to handle the runtime dependency on glibc.
  
  
  I don't think that's possible, no.

INLINE COMMENTS

> file.cpp:71
> +#include <sys/stat.h>
> +#define USE_STATX STATX_BASIC_STATS && __GLIBC__
> +#endif

This won't work as expected, `USE_STATX` is unconditionally defined.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20096

To: meven, #frameworks, dfaure, fvogt, bruns, broulik
Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190331/a5711a5e/attachment.html>