D20133: [UserMetaData] Untangle Windows, Linux/BSD/Mac and stub code.

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, Windows, FreeBSD, ngraham, astippich.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The Windows code only shares the function signature with the other
  variants, while the actual code is vastly different. One example are
  path and attribute names, which are UTF-16 on Windows and UTF-8 otherwise,
  but QFile::encodeName() is also called on Windows.
  
  This fixes also two small bugs on Windows, one missing CloseHandle in
  case the attribute has a size of 0, and a wrong return value in case
  writing the ADS fails.

TEST PLAN
  Linux: ctest
  Windows/Mac/*BSD: untested

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20133

AFFECTED FILES
  src/xattr_p.h

To: bruns, #baloo, #frameworks, #windows, #freebsd, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190330/470ef37c/attachment.html>