D20101: [timeline] Canonicalize Url

Nathaniel Graham noreply at phabricator.kde.org
Fri Mar 29 23:10:57 GMT 2019


ngraham added inline comments.

INLINE COMMENTS

> kio_timeline.cpp:134
>  {
> +    auto canonicalUrl = canonicalizeTimelineUrl(url);
> +    if (url != canonicalUrl) {

Any reason not to make the type explicit?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D20101

To: bruns, #baloo, #frameworks, poboiko, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190329/5144741c/attachment.html>


More information about the Kde-frameworks-devel mailing list