D20007: Add GetProcessList for retrieving the list of currently active processes

David Hallas noreply at phabricator.kde.org
Wed Mar 27 18:46:55 GMT 2019


hallas added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kprocesslisttest.cpp:38
> KUser::KUser()
> 
> (fortunately it's in kcoreaddons!)

Nice :) I didn't know that one

> davidedmundson wrote in kprocesslisttest.cpp:52
> qint64 QCoreApplication::applicationPid()

Got it - I have reworked the tests a bit, so I think they are now cross-platform :D

> davidedmundson wrote in kprocesslist.cpp:72
> delete d_ptr;
> 
> OR
> 
> replace make d_ptr a QScopedPointer
> 
> OR
> 
> make it a QSharedDataPointer  and our KProcessInfoPrivate inherit from QSharedData
> (which is a bit more work but my favourite option)

I went for your favorite ;)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D20007

To: hallas, davidedmundson, broulik
Cc: vonreth, adridg, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190327/247ccd3d/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list