D20032: Convert string formatting tests to be data driven

Stefan BrĂ¼ns noreply at phabricator.kde.org
Mon Mar 25 14:06:14 GMT 2019


bruns added inline comments.

INLINE COMMENTS

> apol wrote in propertyinfotest.cpp:71
> And instead it makes you create a weird local struct and loop to feed to QTest. I don't find it very convincing.

First 2 rows expanded, just for you:

  QTest::addRow("%s", PropertyInfo(DiscNumber).displayName().toUtf8().constData()) << PropertyInfo(Property::DiscNumber) << true << QVariant(2018) << QStringLiteral("2018");
  QTest::addRow("%s", PropertyInfo(Title).displayName().toUtf8().constData()) << PropertyInfo(Property::Title) << true << QVariant(QStringLiteral("Title")) << QStringLiteral("Title");

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20032

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: apol, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190325/f2e4a001/attachment.html>


More information about the Kde-frameworks-devel mailing list