D20041: [balooctl] Reduce nesting level for addOption arguments, cleanup

Stefan BrĂ¼ns noreply at phabricator.kde.org
Mon Mar 25 13:39:13 GMT 2019


bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, poboiko, astippich.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The high nesting level makes the call hard to read, split it up.
  
  Cleanup i18n somewhat, add context, remove "default" from the verbatim
  option value, i.e. make it translatable. Remove trailing/spurious
  whitespace.

TEST PLAN
  no functional change

REPOSITORY
  R293 Baloo

BRANCH
  cleanup

REVISION DETAIL
  https://phabricator.kde.org/D20041

AFFECTED FILES
  src/tools/balooctl/main.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190325/3f0741f6/attachment.html>


More information about the Kde-frameworks-devel mailing list