D20013: Use Qt function for string list formatting

Stefan BrĂ¼ns noreply at phabricator.kde.org
Mon Mar 25 12:41:42 GMT 2019


bruns added a comment.


  I think this should go in before D19445 <https://phabricator.kde.org/D19445>.

INLINE COMMENTS

> propertyinfo.cpp:635
>          if (d->valueType == QVariant::StringList || d->valueType == QVariant::String ) {
>              return FormatStrings::joinStringListFunction(value);
>          } else {

unnecessary indirection

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20013

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190325/73df55c4/attachment.html>


More information about the Kde-frameworks-devel mailing list