D20026: WIP: Bug 195801 - go up in folder hierachy when in "edit mode"

[Mikhail Krutov]

krutovmikhail added a comment.


  I've updated the diff with a couple questions I have (about UI mostly). Still WIP.

INLINE COMMENTS

> kurlnavigator.cpp:406
> +        hasParent = (currentDirectory != currentDirectory.resolved(levelUp));
> +        currentDirectory = QUrl(parentDirectory(currentDirectory));
> +    }

QUrl(currentDirectory.resolved(levelUp)) for some reason results in missed 1st level directory, eg list for /home/neko would be:

  /home/neko
  /

Is this a proper approach or should I do it somehow differently?

> kurlnavigator.cpp:408
> +    }
> +    QMenu *dropdown = new QMenu(q);
> +    auto itBegin = hierarchyList->begin();

Is QMenu a proper widget for dropdown list here?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20026

To: krutovmikhail, ngraham, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190325/e57f38b2/attachment.html>