D19784: Avoid calling QT_LSTAT and accessing recent documents

Robert Hoffmann noreply at phabricator.kde.org
Mon Mar 25 06:53:30 GMT 2019


hoffmannrobert added a comment.


  In D19784#437715 <https://phabricator.kde.org/D19784#437715>, @dfaure wrote:
  
  >
  
  
  ...
  
  > Indeed this doesn't need the stat() done by KFileItem's init(). This means the right solution is indeed for KFileItem to do that stat() on demand, and this code doesn't need any changes.
  
  Wait, my comment about recent files only refers to this bug: https://bugs.kde.org/show_bug.cgi?id=373352
  
  The original problem about the application menu not responding can still be solved by not doing the stat() in the KFileItemPrivate::init() AND not doing the mime type determination by content.
  
  So, as you say in https://phabricator.kde.org/D19887 the init() (and the stat()) should be done only on demand and the new KFileItem constructor with the SkipMimetypeDetermination parameter should be called from here.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19784

To: hoffmannrobert, #frameworks, dfaure, #dolphin
Cc: apol, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190325/7b0e49a9/attachment.html>


More information about the Kde-frameworks-devel mailing list