D20020: Split ffmpeg tests into video properties and metadata tests

Stefan BrĂ¼ns noreply at phabricator.kde.org
Sun Mar 24 18:24:20 GMT 2019


bruns added a comment.


  ..., otherwise, LGTM

INLINE COMMENTS

> ffmpegextractortest.cpp:53
>  
> -void ffmpegExtractorTest::videoTest()
> +//test only for testing intrinsic video properties
> +void ffmpegExtractorTest::testVideoProperties()

a little bit to much "test" here ;)
and missing space

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20020

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190324/ac939ab3/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list