D20016: Don't set a null completer on a non-editable combobox

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> dfaure wrote in kcombobox.cpp:60
> Are you sure the line shouldn't be moved under this if()? It wouldn't warn here, since that's the case where it's editable.
> 
> At least this seems safer, unless you did the additional research of whether (or not) there is indeed a completer that we want to remove on editable comboboxes.

`init()` is never called on an editable combobox, if I'm not wrong. But you are right, that should be safer and would still prevent the warning.

REPOSITORY
  R284 KCompletion

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20016

To: elvisangelaccio, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190324/fab59fa4/attachment.html>