D20016: Don't set a null completer on a non-editable combobox

Elvis Angelaccio noreply at phabricator.kde.org
Sun Mar 24 12:16:23 GMT 2019


elvisangelaccio created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
elvisangelaccio requested review of this revision.

REVISION SUMMARY
  This was a no-op before and prints the following warning since 5.13:
  
    Setting a QCompleter on non-editable QComboBox is not allowed.
  
  See also https://codereview.qt-project.org/#/c/243045/4

TEST PLAN
  Start dolphin with/without this patch.

REPOSITORY
  R284 KCompletion

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20016

AFFECTED FILES
  src/kcombobox.cpp

To: elvisangelaccio
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190324/f4706eff/attachment.html>


More information about the Kde-frameworks-devel mailing list